avoid recursion

README.md

@@ -31,5 +31,24 @@ Das sind die verwendeten Libraries [1]:
 | https://github.com/mcci-catena/SHT1x.git  | be7042c | Tue, 20 Sep 2011 13:56:23 +1000  |
 
 
+Patch arduino-lmic, so initial SF10 is used initially:
+
+`
+[joerg@cinnamon src]$ git diff
+diff --git a/src/lmic/lmic_bandplan_eu868.h b/src/lmic/lmic_bandplan_eu868.h
+index efff7d5..74efb37 100644
+--- a/src/lmic/lmic_bandplan_eu868.h
++++ b/src/lmic/lmic_bandplan_eu868.h
+@@ -61,7 +61,7 @@ LMICeu868_isValidBeacon1(const uint8_t *d) {
+ #undef LMICbandplan_isFSK
+ #define LMICbandplan_isFSK()    (/* RX datarate */LMIC.dndr == EU868_DR_FSK)
+ 
+-#define LMICbandplan_getInitialDrJoin() (EU868_DR_SF7)
++#define LMICbandplan_getInitialDrJoin() (EU868_DR_SF10)
+ 
+ void LMICeu868_setBcnRxParams(void);
+ #define LMICbandplan_setBcnRxParams()   LMICeu868_setBcnRxParams()
+`
+
 `[1]:
 [joerg@cinnamon libraries]$ for i in Adafruit_BME280_Library Adafruit_Sensor arduino-lmic arduino-lorawan Catena-Arduino-Platform Catena-mcciadk MCCI_FRAM_I2C Q2-HX711-Arduino-Library SparkFun_Qwiic_Scale_NAU7802_Arduino_Library OneWire SHT1x ; do cd $i; echo "| $(git remote -v |grep fetch |awk '{print $2}' |tr '\n' ' ') | $(git log --pretty=format:'%h | %cD ' -n 1) |" ; cd ..; done`

mini-beieli-node.ino

@@ -110,6 +110,7 @@ long iteration = 0;       // what iteration number do we have, starts with 0
 long package_counter = 0; // sent package counter
 bool send_in_progress = false;
 bool stop_iterations = false;
+bool start_new_iteration = false;
 bool next_package_is_init_package = true;
 uint32_t gRebootMs;
 
@@ -143,17 +144,10 @@ bool fFlash;
 bool fUsbPower;
 
 // have we printed the sleep info?
-bool g_fPrintedSleeping = false;
-
 //  the job that's used to synchronize us with the LMIC code
 static osjob_t iterationJob;
 static osjob_t sendJob;
 
-// the cycle time to use
-unsigned gTxCycle;
-// remaining before we reset to default
-unsigned gTxCycleCount;
-
 void setup(void)
 {
   gCatena.begin();
@@ -253,7 +247,6 @@ void setup_platform(void)
   }
 
   gLoRaWAN.SetReceiveBufferBufferCb(receiveMessage);
-  setTxCycleTime(CATCFG_T_CYCLE_INITIAL, CATCFG_INTERVAL_COUNT_INITIAL);
   gCatena.registerObject(&gLoRaWAN);
 
   /* find the platform */
@@ -348,6 +341,9 @@ void setup_uplink(void)
 
   LMIC_setClockError(1 * 65536 / 100);
 
+  // explicitly enable LinkCheckMode
+  gLoRaWAN.SetLinkCheckMode(true);
+
   /* figure out when to reboot */
   gRebootMs = (CATCFG_T_REBOOT + os_getRndU2() - 32768) * 1000;
 
@@ -379,6 +375,9 @@ void setup_uplink(void)
 void loop()
 {
   gCatena.poll();
+  if (start_new_iteration) {
+    StartNewIteration();
+  }
 }
 
 void ClearLoraData(void)
@@ -503,7 +502,7 @@ uint8_t GetVBatValue(int millivolts)
 void DoDeepSleep(uint32_t sleep_time)
 {
   if (config_data.debug_level > 0) {
-    gCatena.SafePrintf("DoDeepSleep, now going to deep sleep\n");
+    gCatena.SafePrintf("DoDeepSleep, now going to deep sleep, millis: %d\n",millis());
   }
 
   // Prepare Deep Sleep
@@ -520,7 +519,7 @@ void DoDeepSleep(uint32_t sleep_time)
   deepSleepRecovery();
 
   if (config_data.debug_level > 0) {
-    gCatena.SafePrintf("done with deep sleep\n");
+    gCatena.SafePrintf("done with deep sleep, millis: %d\n",millis());
   }
 }
 
@@ -621,6 +620,7 @@ void ReadSensors(SENSOR_data &sensor_data) {
 }
 
 void StartNewIteration() {
+  start_new_iteration = false;
   uint32_t wait_time;
   wait_time = 0;
 
@@ -690,21 +690,30 @@ void StartNewIteration() {
       gLed.Set(LedPattern::TwoShort);
     }
 
-    // Loop while sending is in progress, timeout just in case after 300 seconds
+    // Loop sending is in progress, timeout just in case after 300 seconds
     long start_time = millis();
     if (config_data.debug_level > 0) {
       gCatena.SafePrintf("waiting while send is in progress\n");
     }
     while (send_in_progress && ((millis() - start_time) < 300000))
     {
-      os_runloop_once();
-      delay(10);
+      gCatena.poll();
+      yield();
     }
     // handle timeout...
     if (send_in_progress) {
       if (config_data.debug_level > 0) {
         gCatena.SafePrintf("looks like we timed out waiting for sending to finish...\n", wait_time);
       }
+      LMIC_clrTxData();
+      // we sleep 10 seconds...
+      start_time = millis();
+      while ((millis() - start_time) < 10000)
+      {
+        gCatena.poll();
+        yield();
+      }
+
       send_in_progress = false;
     }
     wait_time = (uint32_t)((millis() - start_time) / 1000);
@@ -726,33 +735,11 @@ void StartNewIteration() {
     sleep_time_sec = 5;
   }
 
-  // for the first <INIT_PACKETS> iterations, we set the sleep time to 10 seconds only...
+  // for the first <INIT_PACKETS> iterations, we set the sleep time to 120 seconds only...
   if (iteration <= INIT_PACKETS) {
-    sleep_time_sec = 10;
+    sleep_time_sec = 120;
   }
 
-  // Before we go to sleep, we'd like to be sure that this is safe!
-  if (config_data.debug_level > 0) {
-    gCatena.SafePrintf("We wait until is is safe to go to sleep...\n");
-  }
-  long loopCount = 0;
-  long prevPrint;
-  while(os_queryTimeCriticalJobs(ms2osticks(8000)) != 0)
-  {
-    loopCount++;
-    os_runloop_once();
-    if(millis() - prevPrint > 1000) {
-      prevPrint = millis();
-      if (config_data.debug_level > 0) {
-        gCatena.SafePrintf("LMIC.opmode: %#x\n", LMIC.opmode);
-      }
-    }
-  }
-  if (config_data.debug_level > 0) {
-    gCatena.SafePrintf("Now it is safe to go to sleep\n");
-  }
-  delay(10);
-
   if (config_data.debug_level > 0) {
     gCatena.SafePrintf("now going to sleep for %d seconds...\n", sleep_time_sec);
     if (fUsbPower) {
@@ -776,15 +763,21 @@ void StartNewIteration() {
     NVIC_SystemReset();
   }
 
+  if (config_data.debug_level > 0) {
+    gCatena.SafePrintf("LMIC.opmode just before Sleeping: %#x\n", LMIC.opmode);
+    gCatena.SafePrintf("LMIC.globalDutyRate: %d, LMIC.globalDutyAvail: %d, os_getTime: %d\n", LMIC.globalDutyRate, LMIC.globalDutyAvail, os_getTime());
+    gCatena.SafePrintf("LMIC.seqnoUp: %d, LMIC.seqnoDn: %d\n",LMIC.seqnoUp, LMIC.seqnoDn);
+  }
 
   if (!fUsbPower) {
     DoDeepSleep(sleep_time_sec);
     if (! stop_iterations) {
-      StartNewIteration();
+      start_new_iteration = true;
     }
 
   }
   else {
+    if (! stop_iterations) {
       if (config_data.debug_level > 0) {
         gCatena.SafePrintf("light sleep; os_setTimedCallback for startNewIterationCb in %d...seconds\n", sleep_time_sec);
       }
@@ -794,6 +787,7 @@ void StartNewIteration() {
         startNewIterationCb);
     }
   }
+}
 
 void startSendingUplink(bool firstTime)
 {
@@ -819,22 +813,42 @@ void startSendingUplink(bool firstTime)
     fConfirmed = true;
   }
 
-  os_runloop_once();
-  //gCatena.poll();
-
   if (firstTime) {
     if (config_data.debug_level > 0) {
       gCatena.SafePrintf("SendBuffer firstTime\n");
     }
-    gLoRaWAN.SendBuffer((uint8_t*)&lora_data_first, sizeof(LORA_data_first), sendBufferDoneCb, NULL, fConfirmed, kUplinkPort);
+    if (gLoRaWAN.SendBuffer((uint8_t*)&lora_data_first, sizeof(LORA_data_first), sendBufferDoneCb, NULL, fConfirmed, kUplinkPort)) {
       package_counter++;
+      if (config_data.debug_level > 0) {
+        gCatena.SafePrintf("LMIC.opmode just after SendBuffer (successful): %#x\n", LMIC.opmode);
+        gCatena.SafePrintf("LMIC.globalDutyRate: %d, LMIC.globalDutyAvail: %d, os_getTime: %d\n", LMIC.globalDutyRate, LMIC.globalDutyAvail, os_getTime());
+        gCatena.SafePrintf("LMIC.seqnoUp: %d, LMIC.seqnoDn: %d\n",LMIC.seqnoUp, LMIC.seqnoDn);
+      }
+    }
+    else {
+      gCatena.SafePrintf("LMIC.opmode just before SendBuffer (failed): %#x\n", LMIC.opmode);
+      gCatena.SafePrintf("LMIC.globalDutyRate: %d, LMIC.globalDutyAvail: %d, os_getTime: %d\n", LMIC.globalDutyRate, LMIC.globalDutyAvail, os_getTime());
+      gCatena.SafePrintf("LMIC.seqnoUp: %d, LMIC.seqnoDn: %d\n",LMIC.seqnoUp, LMIC.seqnoDn);
+    }
   } else {
     if (config_data.debug_level > 0) {
       gCatena.SafePrintf("LMIC.opmode just before SendBuffer: %#x\n", LMIC.opmode);
+      gCatena.SafePrintf("LMIC.globalDutyRate: %d, LMIC.globalDutyAvail: %d, os_getTime: %d\n", LMIC.globalDutyRate, LMIC.globalDutyAvail, os_getTime());
+      gCatena.SafePrintf("LMIC.seqnoUp: %d, LMIC.seqnoDn: %d\n",LMIC.seqnoUp, LMIC.seqnoDn);
       gCatena.SafePrintf("SendBuffer not firstTime\n");
     }
-    gLoRaWAN.SendBuffer((uint8_t*)&lora_data, sizeof(LORA_data), sendBufferDoneCb, NULL, fConfirmed, kUplinkPort);
+    if (gLoRaWAN.SendBuffer((uint8_t*)&lora_data, sizeof(LORA_data), sendBufferDoneCb, NULL, fConfirmed, kUplinkPort)) {
       package_counter++;
+      if (config_data.debug_level > 0) {
+        gCatena.SafePrintf("LMIC.opmode just after SendBuffer (successful): %#x\n", LMIC.opmode);
+        gCatena.SafePrintf("LMIC.globalDutyRate: %d, LMIC.globalDutyAvail: %d, os_getTime: %d\n", LMIC.globalDutyRate, LMIC.globalDutyAvail, os_getTime());
+        gCatena.SafePrintf("LMIC.seqnoUp: %d, LMIC.seqnoDn: %d\n",LMIC.seqnoUp, LMIC.seqnoDn);
+      }
+    } else {
+      gCatena.SafePrintf("LMIC.opmode just before SendBuffer (failed): %#x\n", LMIC.opmode);
+      gCatena.SafePrintf("LMIC.globalDutyRate: %d, LMIC.globalDutyAvail: %d, os_getTime: %d\n", LMIC.globalDutyRate, LMIC.globalDutyAvail, os_getTime());
+      gCatena.SafePrintf("LMIC.seqnoUp: %d, LMIC.seqnoDn: %d\n",LMIC.seqnoUp, LMIC.seqnoDn);
+    }
   }
 
   ClearLoraData();
@@ -846,8 +860,6 @@ static void sendBufferDoneCb(
 {
   osjobcb_t pFn;
 
-  send_in_progress = false;
-
   if (config_data.debug_level > 1) {
     gLed.Set(LedPattern::Settling);
     gCatena.SafePrintf("LMIC.opmode in sendBufferDoneCb: %#x\n", LMIC.opmode);
@@ -889,6 +901,37 @@ static void txNotProvisionedCb(
   }
 }
 
+bool checkDeepSleep(void)
+{
+  return !fUsbPower;
+}
+
+void doSleepAlert(const bool fDeepSleep)
+{
+  if (config_data.debug_level > 0) {
+    gCatena.SafePrintf("We wait until is is safe to go to sleep...\n");
+  }
+
+  for (int i = 0; i <= 15; i++) {
+    long prevPrint = millis();
+    while (os_queryTimeCriticalJobs(ms2osticks(2000)) != 0)
+    {
+      gCatena.poll();
+      yield();
+      if (millis() - prevPrint > 1000) {
+        prevPrint = millis();
+        if (config_data.debug_level > 0) {
+          gCatena.SafePrintf("LMIC.opmode: %#x in loop %d\n", LMIC.opmode, i);
+        }
+      }
+    }
+  }
+
+  if (config_data.debug_level > 0) {
+    gCatena.SafePrintf("Now it is safe to go to sleep\n");
+  }
+
+}
 
 static void settleDoneCb(
   osjob_t* pSendJob)
@@ -896,6 +939,18 @@ static void settleDoneCb(
   if (config_data.debug_level > 0) {
     gCatena.SafePrintf("settleDoneCb - we are at the end of the callback chain!\n");
   }
+
+  const bool fDeepSleep = checkDeepSleep();
+
+  if (uint32_t(millis()) > gRebootMs)
+  {
+    // time to reboot
+    NVIC_SystemReset();
+  }
+
+  doSleepAlert(fDeepSleep);
+
+  send_in_progress = false;
 }
 
 void deepSleepPrepare(void)
@@ -925,14 +980,12 @@ static void startNewIterationCb(osjob_t* pJob)
   }
 
   if (! stop_iterations) {
-    StartNewIteration();
+    start_new_iteration = true;
   }
 }
 
 static void receiveMessage(void *pContext, uint8_t port, const uint8_t *pMessage, size_t nMessage)
 {
-  unsigned txCycle;
-  unsigned txCount;
 
   long cal_w1_0;
   long cal_w2_0;
@@ -1048,59 +1101,8 @@ static void receiveMessage(void *pContext, uint8_t port, const uint8_t *pMessage
     }
   }
 
-  if (port == 0)
-  {
-    return;
 }
 
-  else if (! (port == 1 && 2 <= nMessage && nMessage <= 3))
-  {
-    if (config_data.debug_level > 0) {
-      gCatena.SafePrintf("invalid message port(%02x)/length(%x)\n",
-                         port, nMessage
-                        );
-    }
-    return;
-  }
-
-  txCycle = (pMessage[0] << 8) | pMessage[1];
-
-  if (txCycle < CATCFG_T_MIN || txCycle > CATCFG_T_MAX)
-  {
-    if (config_data.debug_level > 0) {
-      gCatena.SafePrintf("tx cycle time out of range: %u\n", txCycle);
-    }
-    return;
-  }
-
-  // byte [2], if present, is the repeat count.
-  // explicitly sending zero causes it to stick.
-  txCount = CATCFG_INTERVAL_COUNT;
-  if (nMessage >= 3)
-  {
-    txCount = pMessage[2];
-  }
-
-  setTxCycleTime(txCycle, txCount);
-
-}
-
-void setTxCycleTime(unsigned txCycle, unsigned txCount)
-{
-  if (txCount > 0) {
-    if (config_data.debug_level > 0) {
-      gCatena.SafePrintf("message cycle time %u seconds for %u messages\n", txCycle, txCount);
-    }
-  }
-  else if (config_data.debug_level > 0) {
-    gCatena.SafePrintf("message cycle time %u seconds indefinitely\n", txCycle);
-  }
-
-  gTxCycle = txCycle;
-  gTxCycleCount = txCount;
-}
-
-
 /* process "application hello" -- args are ignored */
 // argv[0] is "hello"
 // argv[1..argc-1] are the (ignored) arguments

mini_beieli_node.h

@@ -56,7 +56,7 @@ enum {
   |
   \****************************************************************************/
 
-static const int32_t fwVersion = 20200530;
+static const int32_t fwVersion = 20200606;
 
 static const byte INIT_PACKAGE_INTERVAL = 100;  // send an init package every 100 packages;
 static const byte MAX_VALUES_TO_SEND = 8;